fix(@angular/build): skip normalization of relative externals #30046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-stepanenko
force-pushed
the
ds/skip-normalization-of-relative-externals
branch
from
dbfa61a to
7a4fde9
Compare
alan-agius4
reviewed
Apr 7, 2025
alan-agius4
added
target: patch
dmitry-stepanenko
force-pushed
the
ds/skip-normalization-of-relative-externals
branch
from
7a4fde9 to
3a7930d
Compare
alan-agius4
approved these changes
Apr 7, 2025
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In this PR #29753 there was a regression that now prevents corrent handling of external local dependencies. In my case the configuration for the build target looks like this
"externalDependencies": ["/assets/js/*"]. This ensures that all scripts in the given folder are marked as external.With the change in the PR mentioned above this no longer works. To bring back the old behavior I'm adding an extra condition to check whether provided dependency is indeed a package name or a relative/absolute path.
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information